GitHub Actions: preparations, part 2 #67733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In their infinite wisdom, Apple decided that (starting from macOS 10.15 onwards) /usr/include is not the location we should all search in for our beloved C headers. Instead, we should look inside the extremely intuitive and easily guessable new path: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include Because why not.
rust-highfive
added
the
S-waiting-on-review
mati865
reviewed
Dec 30, 2019
| @@ -6,7 +6,8 @@ IFS=$'\n\t' | |||
| source "$(cd "$(dirname "$0")" && pwd)/../shared.sh" | |||
|
|
|||
| if isWindows; then | |||
| pacman -S --noconfirm --needed base-devel ca-certificates make diffutils tar | |||
| pacman -S --noconfirm --needed base-devel ca-certificates make diffutils tar \ | |||
| binutils | |||
There was a problem hiding this comment.
It's weird, they are provided by mingw-w64 toolchain (in a version that really works for Windows).
|
@bors: r+ |
|
📌 Commit 39ddbeb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 8, 2020
GitHub Actions: preparations, part 2 This PR adds the second batch of commits in preparation for GitHub Actions: * Removed hardcoded Azure Pipelines variables from `publish_toolstate.sh` * Fixed a bug in `shared.sh`'s GitHub Actions support * Fixed binutils missing from MSYS2 on Windows 2019 (GitHub Actions-specific) * Fixed wrong sysroot in macOS 10.15 onwards (GitHub Actions-specific) This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton
|
☀️ Test successful - checks-azure |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
JohnTitor
reviewed
Jan 8, 2020
| set -euo pipefail | ||
| IFS=$'\n\t' | ||
|
|
||
| source "$(cd "$(dirname "$0")" && pwd)/../shared.sh" |
There was a problem hiding this comment.
Probably source "$(cd "$(dirname "$0")" && pwd)/shared.sh"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the second batch of commits in preparation for GitHub Actions:
publish_toolstate.shshared.sh's GitHub Actions supportThis PR does not yet add any builders on GitHub Actions.
r? @alexcrichton