Add builtin Sized kind and a few basic tests #6852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we deal with unreachable expressions in trans is pretty ad hoc, but this at least doesn't make it worse, and eliminates the LLVM assertion failure reported in rust-lang#5741.
…tsakis r? @nikomatsakis The way we deal with unreachable expressions in trans is pretty ad hoc, but this at least doesn't make it worse, and eliminates the LLVM assertion failure reported in rust-lang#5741.
This fixes segmentation fault of new rt tests.
For example
```
use core::rt::test::*;
use core::rt::comm::*;
use core::cell::Cell;
fn main() {
do run_in_newsched_task {
let (port, chan) = oneshot::<~int>();
let port_cell = Cell(port);
do spawntask_immediately {
assert!(port_cell.take().recv() == ~10);
}
chan.send(~10);
}
}
```
This verifies that a static item evaluates to true, at compile time.
This verifies that a static item evaluates to true, at compile time.
The error message is extremely unideal.
Fix issue rust-lang#6209, and some related issues about constant expression - unmatched type between arms - unmatched type in range
Implement SmallIntSet (refer rust-lang#4984)
This can perhaps be restored in the future. For now this is a precursor to making typedefs work as expected.
…with -O0. This improves -O0 compile times dramatically.
Show `int_suffix_size` to appear 0 or 1 times Show `exponent | . dec_lit` to appear 0 or 1 times, to show why `3f;` is a valid number
Show `int_suffix_size` to appear 0 or 1 times Show `exponent | . dec_lit` to appear 0 or 1 times, to show why `3f;` is a valid number
Add some more cases for warning about missing documentation, and also add a test to make sure it doesn't die in the future.
Adds documentation for various things that I understand. Adds #[allow(missing_doc)] for lots of things that I don't understand.
These commits perform a variety of actions: 1. The linting of missing documentation has been consolidated under one `missing_doc` attribute, and many more things are linted about. 2. A test was added for linting missing documentation, which revealed a large number of corner cases in both linting and the `missing_doc` lint pass. Some notable edge cases: * When compiling with `--test`, all `missing_doc` warnings are suppressed * If any parent of the current item has `#[doc(hidden)]`, then the `missing_doc` warning is suppressed 3. Both the std and extra libraries were modified to `#[deny(missing_doc)]` by default. I believe that the libraries are getting to the point where they're fairly well documented, and they should definitely stay that way. If developing a particular new module, it's easy enough to add `#[allow(missing_doc)]` at the top, but those should definitely be flags for removal in favor of actual documentation. I added as much documentation as I could throughout std/extra, although I avoided trying to document things that I knew nothing about. I can't say that this lint pass will vouch for the quality of the documentation of std/extra, but it will certainly make sure that there's at least some describing words. That being said, I may have a different opinion, so I don't mind amending these commits to turn off the lint by default for std/extra if people think otherwise.
Minor doc enhancement for: rust-lang#4543
current svn version is 3.4
…rite-basedir, r=catamorphism Attempt to get reuse of common object code from multiple clones in different directories. This is a followup to issue rust-lang#6805.
…ts, r=graydon Re-enables `make check-stage2-doc-tutorial` and friends. r? @brson
|
oh my goodness I did something wrong |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 11, 2021
Remove a couple MIR usages changelog: none We use MIR to get the return type of a closure/function in a couple places. But typeck seems like a better approach. This is the easy part of rust-lang#6080. Also did a tiny cleanup with `typeck` -> `typeck_body`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis @pcwalton