Skip to content

check_unsafety: more code reuse #68588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

check_unsafety: more code reuse #68588

merged 1 commit into from
Jan 31, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 28, 2020 •
edited by Mark-Simulacrum
Loading

r? oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2020
@Mark-Simulacrum
Copy link
Member

Looks like this is equivalent in practice, so @bors r+ rollup

r? @Mark-Simulacrum

(also edited the parent to strip out @ to avoid pinging Oli on all merges)

@bors
Copy link
Collaborator

bors commented Jan 30, 2020

📌 Commit dc17f38 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 31, 2020
@Dylan-DPC
Rollup merge of rust-lang#68588 - Centril:check-unsafety-clean, r=Mar…
8f58580 
…k-Simulacrum

check_unsafety: more code reuse

r? oli-obk
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 31, 2020
Merged
bors added a commit that referenced this pull request Jan 31, 2020
@bors
Auto merge of #68685 - Dylan-DPC:rollup-rkbo05z, r=Dylan-DPC
266ecd6 
Rollup of 6 pull requests

Successful merges:

 - #68588 (check_unsafety: more code reuse)
 - #68638 (Add missing links for cmp traits)
 - #68660 (Fix typo.)
 - #68669 (suggest adding space in accidental doc comments)
 - #68670 (clarify "incorrect issue" error)
 - #68680 (Add `#![doc(html_playground_url = ...)]` to alloc crate)

Failed merges:

r? @ghost
@bors bors merged commit dc17f38 into rust-lang:master Jan 31, 2020
@Centril Centril deleted the check-unsafety-clean branch January 31, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @Mark-Simulacrum @bors @oli-obk @rust-highfive