-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Don't use static crt by default when build proc-macro #69519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
7ca1b2f
7996df9
89aebbd
84349cc
dbed65a
7a89bf1
75e6cfc
cfff1b4
afd374f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,15 @@ | ||||
// Test proc-macro crate can be built without addtional RUSTFLAGS | ||||
// on musl target | ||||
|
||||
// build-pass | ||||
// only-musl | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test doesn't depend on any musl-specific functionality, so I would expect it to run everywhere. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It depend on musl target but CI don't have it.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Which CI job was it? This is a problem with the CI configuration, not something that needs to be worked around in the test. Specifically, the musl targets built by CI are missing the dynamic version of
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @smaeul it failed on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I see, the old version of the test had So since the behavior tested here is not musl-specific, I would suggest 1) removing |
||||
#![crate_type = "proc-macro"] | ||||
|
||||
extern crate proc_macro; | ||||
|
||||
use proc_macro::TokenStream; | ||||
|
||||
#[proc_macro_derive(Foo)] | ||||
pub fn derive_foo(input: TokenStream) -> TokenStream { | ||||
input | ||||
} |
Uh oh!
There was an error while loading. Please reload this page.