-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update rustc-dev-guide #70873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustc-dev-guide #70873
Conversation
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Hm, overall looks good but GitHub returns the 429 status code. IIRC I've seen this failure on rustc-dev-guide side also. Can we avoid this to tweak link checker config or something? |
@JohnTitor I think this code could be updated to filter out 429's: rust/src/tools/rustbook/src/main.rs Lines 106 to 128 in 42abbd8
|
That's a good idea! r=me once it's updated. |
It looks like there are some actually broken links atm, so let me fix those and update this pr too. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Should hopefully pass now. Let's wait for CI. |
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author @JohnTitor ready :) |
Thanks! @bors r+ |
📌 Commit 0d9bf52 has been approved by |
Update rustc-dev-guide This should finally fix toolstate r? @JohnTitor
Failed in #70955 (comment), @bors r- |
This is still passing for me locally? Perhaps it was a spurious failure we didn't expect? I looked through the log, but it's long and I guess I missed whatever error caused the failure. |
Looks spurious to me, though I feel like maybe we shouldn't be running linkcheck quite like this in CI... I have no better suggestions necessarily though, just feeling a bit like we'll likely hit errors like this frequently? @bors r=JohnTitor |
📌 Commit 0d9bf52 has been approved by |
At a glance, the real error is
only and it's spurious. The current link check emits all the errors including filtered ones when there's a real error, it isn't ideal.. |
@JohnTitor It's definitely worth re-evaluating whether it's really doing its job here... |
@mark-i-m You point to emitting the errors, right? Hm, fair enough. Anyway we should deal with the GH links' failures properly if it continues. |
☀️ Test successful - checks-azure |
📣 Toolstate changed by #70873! Tested on commit 4d1fbac. 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m). |
Tested on commit rust-lang/rust@4d1fbac. Direct link to PR: <rust-lang/rust#70873> 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
This should finally fix toolstate
r? @JohnTitor