Skip to content

Update compiler_builtins to 0.1.29 #72629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented May 26, 2020

Differences rust-lang/compiler-builtins@0.1.28...0.1.29:

  • Add more targets to automatically select mem feature
  • Use crate visibility for traits

Fixes #71090.
Fixes #71532.

* Add more targets to automatically select `mem` feature
* Use crate visibility for traits
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2020
@Mark-Simulacrum
Copy link
Member

cc @Amanieu @bors r+

@bors
Copy link
Collaborator

bors commented May 26, 2020

📌 Commit d42e0e7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2020
@ehuss ehuss mentioned this pull request May 29, 2020
@JohnTitor
Copy link
Member

Triage: This is now superseded by #72759.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
5 participants