Skip to content

RELEASES.md: Expand cargo tree note to mention cargo tree -d #72832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

joshtriplett
Copy link
Member

Useful feature that people might not automatically associate with cargo tree.

Useful feature that people might not automatically associate with `cargo
tree`.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2020
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label May 31, 2020
@joshtriplett
Copy link
Member Author

cc @XAMPPRocky

@Mark-Simulacrum
Copy link
Member

Hm, I think we generally try to avoid going into too much depth, but on the other hand it does seem like an important use case. Maybe we should include it in the blog post instead? rust-lang/blog.rust-lang.org#604

But I'm not opposed to doing both! I'm interested in hearing thoughts on this - if no one chimes in I'll most likely include this in the stable release.

@joshtriplett
Copy link
Member Author

joshtriplett commented May 31, 2020

@Mark-Simulacrum I definitely don't want to go into unnecessary depth, but this is a distinct function people wouldn't ordinarily associate with cargo tree unless they'd used the out-of-tree cargo tree -d command before. One sentence letting people know the functionality exists seems warranted to me.

I think it belongs in the blog post as well: https://github.com/rust-lang/blog.rust-lang.org/pull/604/files#r432983344

Copy link
Member

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, more information is better in general imo and this doesn’t get too in the weeds.

@Mark-Simulacrum
Copy link
Member

Yeah, I agree it's not obvious that cargo tree can do it.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 31, 2020

📌 Commit 3273660 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72776 (fulfill: try using SmallVec or Box for stalled_on)
 - rust-lang#72818 (Clean up E0622 explanation)
 - rust-lang#72823 (Add descriptions for all queries)
 - rust-lang#72832 (RELEASES.md: Expand `cargo tree` note to mention `cargo tree -d`)
 - rust-lang#72834 (Rephrase term 'non-pointer type')

Failed merges:

r? @ghost
@bors bors merged commit b6a5fea into rust-lang:master Jun 1, 2020
@joshtriplett joshtriplett deleted the cargo-tree-d branch June 14, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants