Skip to content

Move 'probably equal' methods to librustc_parse #75004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2020
Merged

Move 'probably equal' methods to librustc_parse #75004

merged 1 commit into from
Aug 2, 2020

Conversation

Aaron1011
Copy link
Member

This is preparation for PR #73084

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2020
@Aaron1011
Copy link
Member Author

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned oli-obk Aug 1, 2020
@petrochenkov
Copy link
Contributor

r=me after rebase

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2020
@bors
Copy link
Collaborator

bors commented Aug 1, 2020

☔ The latest upstream changes (presumably #74726) made this pull request unmergeable. Please resolve the merge conflicts.

@Aaron1011 Aaron1011 force-pushed the move-probably-equal branch from 7690828 to 183947f Compare August 2, 2020 01:13
@Aaron1011
Copy link
Member Author

@bors r= petrochenkov

@bors
Copy link
Collaborator

bors commented Aug 2, 2020

📌 Commit 183947f has been approved by ``

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2020
@Aaron1011
Copy link
Member Author

@bors r- r=petrochenkov

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2020
@bors
Copy link
Collaborator

bors commented Aug 2, 2020

📌 Commit 183947f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2020
@bors
Copy link
Collaborator

bors commented Aug 2, 2020

⌛ Testing commit 183947f with merge 46cf80d...

@bors
Copy link
Collaborator

bors commented Aug 2, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 46cf80d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2020
@bors bors merged commit 46cf80d into rust-lang:master Aug 2, 2020
@Mark-Simulacrum
Copy link
Member

This was a 1.1% regression for rustdoc on small crates. Probably different inlining decisions made by LLVM, or so? Does not affect rustc.

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Aaron1011 @rust-highfive @petrochenkov @bors @Mark-Simulacrum @cuviper @oli-obk