-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Implement into_keys
and into_values
for associative maps
#75163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e31116a
Add `into_{keys,values}` methods for HashMap
canova 13529f2
Add `into_{keys,values}` methods for BTreeMap
canova 41dd4ee
Add unit tests for new `HashMap::into_{keys,values}` methods
canova 29d9233
Add unit tests for new `BTreeMap::into_{keys,values}` methods
canova 25545ed
Only print the fields that are relevant to iterators for Debug of Int…
canova 16a5217
Change the comment of BTreeMap::into_values
canova 1cdce39
Remove min/max values from IntoValues Iterator implementation
canova 4cd2637
Update the tracking issue number of map_into_keys_values
canova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -872,6 +872,52 @@ where | |
{ | ||
self.base.retain(f) | ||
} | ||
|
||
/// Creates a consuming iterator visiting all the keys in arbitrary order. | ||
/// The map cannot be used after calling this. | ||
/// The iterator element type is `K`. | ||
/// | ||
/// # Examples | ||
/// | ||
/// ``` | ||
/// #![feature(map_into_keys_values)] | ||
/// use std::collections::HashMap; | ||
/// | ||
/// let mut map = HashMap::new(); | ||
/// map.insert("a", 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps it's better an example with |
||
/// map.insert("b", 2); | ||
/// map.insert("c", 3); | ||
/// | ||
/// let vec: Vec<&str> = map.into_keys().collect(); | ||
/// ``` | ||
#[inline] | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
pub fn into_keys(self) -> IntoKeys<K, V> { | ||
IntoKeys { inner: self.into_iter() } | ||
} | ||
|
||
/// Creates a consuming iterator visiting all the values in arbitrary order. | ||
/// The map cannot be used after calling this. | ||
/// The iterator element type is `V`. | ||
/// | ||
/// # Examples | ||
/// | ||
/// ``` | ||
/// #![feature(map_into_keys_values)] | ||
/// use std::collections::HashMap; | ||
/// | ||
/// let mut map = HashMap::new(); | ||
/// map.insert("a", 1); | ||
/// map.insert("b", 2); | ||
/// map.insert("c", 3); | ||
/// | ||
/// let vec: Vec<i32> = map.into_values().collect(); | ||
/// ``` | ||
#[inline] | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
pub fn into_values(self) -> IntoValues<K, V> { | ||
IntoValues { inner: self.into_iter() } | ||
} | ||
} | ||
|
||
impl<K, V, S> HashMap<K, V, S> | ||
|
@@ -1154,6 +1200,28 @@ pub struct ValuesMut<'a, K: 'a, V: 'a> { | |
inner: IterMut<'a, K, V>, | ||
} | ||
|
||
/// An owning iterator over the keys of a `HashMap`. | ||
/// | ||
/// This `struct` is created by the [`into_keys`] method on [`HashMap`]. | ||
/// See its documentation for more. | ||
/// | ||
/// [`into_keys`]: HashMap::into_keys | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
pub struct IntoKeys<K, V> { | ||
inner: IntoIter<K, V>, | ||
} | ||
|
||
/// An owning iterator over the values of a `HashMap`. | ||
/// | ||
/// This `struct` is created by the [`into_values`] method on [`HashMap`]. | ||
/// See its documentation for more. | ||
/// | ||
/// [`into_values`]: HashMap::into_values | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
pub struct IntoValues<K, V> { | ||
inner: IntoIter<K, V>, | ||
} | ||
|
||
/// A builder for computing where in a HashMap a key-value pair would be stored. | ||
/// | ||
/// See the [`HashMap::raw_entry_mut`] docs for usage examples. | ||
|
@@ -1827,6 +1895,66 @@ where | |
} | ||
} | ||
|
||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> Iterator for IntoKeys<K, V> { | ||
type Item = K; | ||
|
||
#[inline] | ||
fn next(&mut self) -> Option<K> { | ||
self.inner.next().map(|(k, _)| k) | ||
} | ||
#[inline] | ||
fn size_hint(&self) -> (usize, Option<usize>) { | ||
self.inner.size_hint() | ||
} | ||
} | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> ExactSizeIterator for IntoKeys<K, V> { | ||
#[inline] | ||
fn len(&self) -> usize { | ||
self.inner.len() | ||
} | ||
} | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> FusedIterator for IntoKeys<K, V> {} | ||
|
||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K: Debug, V: Debug> fmt::Debug for IntoKeys<K, V> { | ||
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
f.debug_list().entries(self.inner.iter().map(|(k, _)| k)).finish() | ||
} | ||
} | ||
|
||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> Iterator for IntoValues<K, V> { | ||
type Item = V; | ||
|
||
#[inline] | ||
fn next(&mut self) -> Option<V> { | ||
self.inner.next().map(|(_, v)| v) | ||
} | ||
#[inline] | ||
fn size_hint(&self) -> (usize, Option<usize>) { | ||
self.inner.size_hint() | ||
} | ||
} | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> ExactSizeIterator for IntoValues<K, V> { | ||
#[inline] | ||
fn len(&self) -> usize { | ||
self.inner.len() | ||
} | ||
} | ||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K, V> FusedIterator for IntoValues<K, V> {} | ||
|
||
#[unstable(feature = "map_into_keys_values", issue = "75294")] | ||
impl<K: Debug, V: Debug> fmt::Debug for IntoValues<K, V> { | ||
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
f.debug_list().entries(self.inner.iter().map(|(_, v)| v)).finish() | ||
} | ||
} | ||
|
||
#[stable(feature = "drain", since = "1.6.0")] | ||
impl<'a, K, V> Iterator for Drain<'a, K, V> { | ||
type Item = (K, V); | ||
|
@@ -3084,6 +3212,30 @@ mod test_map { | |
assert!(values.contains(&6)); | ||
} | ||
|
||
#[test] | ||
fn test_into_keys() { | ||
let vec = vec![(1, 'a'), (2, 'b'), (3, 'c')]; | ||
let map: HashMap<_, _> = vec.into_iter().collect(); | ||
let keys: Vec<_> = map.into_keys().collect(); | ||
|
||
assert_eq!(keys.len(), 3); | ||
assert!(keys.contains(&1)); | ||
assert!(keys.contains(&2)); | ||
assert!(keys.contains(&3)); | ||
} | ||
|
||
#[test] | ||
fn test_into_values() { | ||
let vec = vec![(1, 'a'), (2, 'b'), (3, 'c')]; | ||
let map: HashMap<_, _> = vec.into_iter().collect(); | ||
let values: Vec<_> = map.into_values().collect(); | ||
|
||
assert_eq!(values.len(), 3); | ||
assert!(values.contains(&'a')); | ||
assert!(values.contains(&'b')); | ||
assert!(values.contains(&'c')); | ||
} | ||
|
||
#[test] | ||
fn test_find() { | ||
let mut m = HashMap::new(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
IntoKeys
and impls should be moved to a module file to remove this tidy ignore.