Record query name when profiling "metadata_decode_entry"

[Aaron1011]

No description provided.

[rust-highfive]

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

[Aaron1011]

cc @Mark-Simulacrum: It is possible to get this to show up on perf.rust-lang.org?

[Mark-Simulacrum]

I don't think so. We could just concat! the query name though (e.g., metadata_decode_item_attrs)

[Aaron1011]

@Mark-Simulacrum: I've updated the PR to use concat!

[Mark-Simulacrum]

@bors try @rust-timer queue include=helloworld

(Testing out new subset functionality; we shouldn't need a full build to test that this does what we expect)

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit c9bd943 with merge 7534f1a4e75fd5e77b5db839bf19bb120e72935e...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 7534f1a4e75fd5e77b5db839bf19bb120e72935e (7534f1a4e75fd5e77b5db839bf19bb120e72935e)

[rust-timer]

Queued 7534f1a4e75fd5e77b5db839bf19bb120e72935e with parent 4b0882c, future comparison URL.

[rust-timer]

Finished benchmarking try commit (7534f1a4e75fd5e77b5db839bf19bb120e72935e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[Mark-Simulacrum]

Looks like it's working, see for example https://perf.rust-lang.org/detailed-query.html?sort_idx=-5&commit=7534f1a4e75fd5e77b5db839bf19bb120e72935e&benchmark=helloworld-opt&run_name=full

I think this will indeed be useful to determine if regressions are coming from metadata loading or not -- right now it's hard to tell. We might even want to do some post-processing within perf to put these in a separate column, but I'm not sure about that.

@bors r+

[bors]

📌 Commit c9bd943 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit c9bd943 with merge 0d75c91...

[bors]

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 0d75c91 to master...