Skip to content

Feature/memory api #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2013
Merged

Feature/memory api #7528

merged 5 commits into from
Jul 9, 2013

Conversation

indutny
Copy link
Contributor

@indutny indutny commented Jul 1, 2013

@cmr this is still WIP and I haven't tested it on windows, but anyway.

}
}

// More recursive_mkdir tests are in std::tempfile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops...

@indutny
Copy link
Contributor Author

indutny commented Jul 1, 2013

@cmr I think its ready, r?

@indutny
Copy link
Contributor Author

indutny commented Jul 3, 2013

@cmr I've slightly changed naming and made test cover the most of the APIs, please consider r? it ;)

@indutny
Copy link
Contributor Author

indutny commented Jul 3, 2013

@cmr there was stupid mistake in previous mman commits, making some constants unavailable on non-mips linuxes, I've added fix commit to this PR to make bors build this patch. r?

@graydon
Copy link
Contributor

graydon commented Jul 3, 2013

Most recent failure was real, a 32bit linux one:

http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/248/steps/test/logs/stdio

@indutny
Copy link
Contributor Author

indutny commented Jul 4, 2013

@graydon thanks, this time should be fixed.

@indutny
Copy link
Contributor Author

indutny commented Jul 7, 2013

@cmr - fixed windows build, can you r?, please?

@indutny
Copy link
Contributor Author

indutny commented Jul 7, 2013

@cmr can you cancel queued job? It seems that I accidentally broke build on linux :(

@emberian
Copy link
Member

emberian commented Jul 7, 2013

the PR that never lands :P

@indutny
Copy link
Contributor Author

indutny commented Jul 7, 2013

@cmr should be fixed now.

@emberian
Copy link
Member

emberian commented Jul 7, 2013

@indutny test os::tests::memory_map_rw ... FAILED on auto-linux-64-opt-vg

@indutny
Copy link
Contributor Author

indutny commented Jul 8, 2013

Got it, that was because of incorrect MAP_ANON value in libc, added fix commit to this PR.

Basically, one may just do:

    MemoryMap::new(16, ~[
      MapExecutable,
      MapReadable,
      MapWritable
    ])

And executable+readable+writable chunk of at least 16 bytes size will be
allocated and freed with the result of `MemoryMap::new`.
bors added a commit that referenced this pull request Jul 9, 2013
@cmr this is still WIP and I haven't tested it on windows, but anyway.
@bors bors closed this Jul 9, 2013
@bors bors merged commit db24ee9 into rust-lang:master Jul 9, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 12, 2021
needless_borrow: try to make lint example a bit more illustrating

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants