-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Feature/memory api #7528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/memory api #7528
Conversation
} | ||
} | ||
|
||
// More recursive_mkdir tests are in std::tempfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops...
@cmr I think its ready, r? |
@cmr I've slightly changed naming and made test cover the most of the APIs, please consider r? it ;) |
@cmr there was stupid mistake in previous mman commits, making some constants unavailable on non-mips linuxes, I've added fix commit to this PR to make bors build this patch. r? |
Most recent failure was real, a 32bit linux one: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/248/steps/test/logs/stdio |
@graydon thanks, this time should be fixed. |
@cmr - fixed windows build, can you r?, please? |
@cmr can you cancel queued job? It seems that I accidentally broke build on linux :( |
the PR that never lands :P |
@cmr should be fixed now. |
@indutny |
Got it, that was because of incorrect |
Basically, one may just do: MemoryMap::new(16, ~[ MapExecutable, MapReadable, MapWritable ]) And executable+readable+writable chunk of at least 16 bytes size will be allocated and freed with the result of `MemoryMap::new`.
@cmr this is still WIP and I haven't tested it on windows, but anyway.
needless_borrow: try to make lint example a bit more illustrating changelog: none
@cmr this is still WIP and I haven't tested it on windows, but anyway.