Skip to content

Detect JS-style === and !== and recover #75321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

Detect JS-style === and !== and recover #75321

merged 1 commit into from
Aug 12, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 9, 2020

Fix #75312.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2020
@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2020

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned eddyb Aug 9, 2020
@estebank estebank mentioned this pull request Aug 9, 2020
Closed
davidtwco
davidtwco approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after resolving existing comments

@kjeremy kjeremy mentioned this pull request Aug 9, 2020
Merged
@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Aug 10, 2020

📌 Commit 308b558 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2020
@bors
Copy link
Collaborator

bors commented Aug 11, 2020

⌛ Testing commit 308b558 with merge 471e6b640dcc8a4ed2ed108044fea31b12df9a54...

@bors
Copy link
Collaborator

bors commented Aug 11, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@estebank
Copy link
Contributor Author

@bors retry

2020-08-11T06:15:26.6759676Z Preparing to unpack .../python3-setuptools_39.0.1-2_all.deb ...
2020-08-11T06:15:26.6805197Z Unpacking python3-setuptools (39.0.1-2) ...
2020-08-11T06:15:26.7645131Z Setting up python3-setuptools (39.0.1-2) ...
2020-08-11T06:15:28.3118620Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2020-08-11T06:15:28.3118927Z                                  Dload  Upload   Total   Spent    Left  Speed
2020-08-11T06:15:28.3119032Z 
2020-08-11T06:15:28.4342240Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
2020-08-11T06:15:28.4342780Z  41 9230k   41 3838k    0     0  30.7M      0 --:--:-- --:--:-- --:--:-- 30.7M
2020-08-11T06:15:28.4342986Z curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 104
2020-08-11T06:15:28.4362538Z tar: Unexpected EOF in archive
2020-08-11T06:15:28.4362826Z tar: Unexpected EOF in archive
2020-08-11T06:15:28.4363255Z tar: Error is not recoverable: exiting now
2020-08-11T06:15:28.4375872Z ##[error]Process completed with exit code 2.
2020-08-11T06:15:28.4445285Z Cleaning up orphan processes
2020-08-11T06:15:28.4843168Z Terminate orphan process: pid (3162) (node)
2020-08-11T06:15:28.4855239Z Terminate orphan process: pid (3190) (python)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020
@bors
Copy link
Collaborator

bors commented Aug 12, 2020

⌛ Testing commit 308b558 with merge 5989bf4...

@bors
Copy link
Collaborator

bors commented Aug 12, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 5989bf4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2020
@bors bors merged commit 5989bf4 into rust-lang:master Aug 12, 2020
@estebank estebank deleted the js-goes-gaga branch November 9, 2023 05:16
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Provide auto-fix suggestion for triple equals
8 participants
@estebank @rust-highfive @bors @rust-log-analyzer @davidtwco @lcnr @cuviper @eddyb