Skip to content

Switch to Snappy compression for metadata #75754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

joshtriplett
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@joshtriplett
Copy link
Member Author

Inspired by #75732 , but easier to ship, and should provide even more performance. Passes tests locally. Let's see how it affects performance.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Aug 20, 2020

⌛ Trying commit 574f6be with merge 50541435b8c0b771394cb492b0b2fbdbc3c3ddd9...

@bors
Copy link
Collaborator

bors commented Aug 21, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 50541435b8c0b771394cb492b0b2fbdbc3c3ddd9 (50541435b8c0b771394cb492b0b2fbdbc3c3ddd9)

@rust-timer
Copy link
Collaborator

Queued 50541435b8c0b771394cb492b0b2fbdbc3c3ddd9 with parent e15510c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (50541435b8c0b771394cb492b0b2fbdbc3c3ddd9): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@joshtriplett joshtriplett added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 21, 2020
@alex
Copy link
Member

alex commented Aug 21, 2020

I don't know this code well, so I'm not sure what compat/iteroperability needs are, but zstd is another compression algorithm that might be interesting to play with. It's a hair slower than snappy, but compresses much more, so the IO savings may be worth the CPU cost: https://facebook.github.io/zstd/

@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 29, 2020

📌 Commit 574f6be has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2020
@Mark-Simulacrum Mark-Simulacrum added relnotes-perf Performance improvements that should be mentioned in the release notes. and removed relnotes-perf Performance improvements that should be mentioned in the release notes. labels Aug 29, 2020
@bors
Copy link
Collaborator

bors commented Aug 29, 2020

⌛ Testing commit 574f6be with merge 7fc048f...

@bors
Copy link
Collaborator

bors commented Aug 29, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 7fc048f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2020
@bors bors merged commit 7fc048f into rust-lang:master Aug 29, 2020
@joshtriplett joshtriplett deleted the wip-perf-snappy branch October 5, 2020 04:42
@cuviper cuviper added this to the 1.48.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants