-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Switch to Snappy compression for metadata #75754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Inspired by #75732 , but easier to ship, and should provide even more performance. Passes tests locally. Let's see how it affects performance. @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 574f6be with merge 50541435b8c0b771394cb492b0b2fbdbc3c3ddd9... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 50541435b8c0b771394cb492b0b2fbdbc3c3ddd9 with parent e15510c, future comparison URL. |
Finished benchmarking try commit (50541435b8c0b771394cb492b0b2fbdbc3c3ddd9): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
I don't know this code well, so I'm not sure what compat/iteroperability needs are, but zstd is another compression algorithm that might be interesting to play with. It's a hair slower than snappy, but compresses much more, so the IO savings may be worth the CPU cost: https://facebook.github.io/zstd/ |
@bors r+ Thanks! |
📌 Commit 574f6be has been approved by |
☀️ Test successful - checks-actions, checks-azure |
No description provided.