Skip to content

Use intra-doc-links in std::sync::* #75790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

Use intra-doc-links in std::sync::* #75790

merged 1 commit into from
Aug 22, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Helps with #75080.
r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2020
@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 21, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020 

tidy error: /checkout/library/std/src/sync/mpsc/mod.rs: ignoring file length unnecessarily

Looks like you cut it down enough you can remove the // ignore-tidy-linelength comment :)

@jyn514
Copy link
Member

jyn514 commented Aug 22, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

📌 Commit f3a832f has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020
@bors
Copy link
Collaborator

bors commented Aug 22, 2020

⌛ Testing commit f3a832f with merge c5a8b7b...

@bors
Copy link
Collaborator

bors commented Aug 22, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing c5a8b7b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2020
@bors bors merged commit c5a8b7b into rust-lang:master Aug 22, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the std-intra-doc branch August 22, 2020 11:24
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LeSeulArtichaut @jyn514 @bors @cuviper @rust-highfive