Skip to content

Improve wording of E0607 explanation #76463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2020
Merged

Improve wording of E0607 explanation #76463

merged 2 commits into from
Sep 9, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 8, 2020

@rustbot modify labels: A-diagnostics C-enhancement

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Sep 8, 2020
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2020
@jyn514 jyn514 added the A-error-codes Area: Explanation of an error code (--explain) label Sep 8, 2020
@camelid camelid force-pushed the improve-E0607-explanation branch from e572a22 to 1f78509 Compare September 8, 2020 01:42
@camelid
Copy link
Member Author

camelid commented Sep 8, 2020

I thought that I might need to run ./x.py test --bless, and I had a good pun for it, but alas I did not need to use it:

Looks like it's time for some blessings!

@jyn514
Copy link
Member

jyn514 commented Sep 8, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 8, 2020

📌 Commit 98a5506 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2020
@bors
Copy link
Collaborator

bors commented Sep 9, 2020

⌛ Testing commit 98a5506 with merge 0855263...

@bors
Copy link
Collaborator

bors commented Sep 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing 0855263 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2020
@bors bors merged commit 0855263 into rust-lang:master Sep 9, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-error-codes Area: Explanation of an error code (--explain) C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camelid @rust-highfive @jyn514 @bors @nikomatsakis @rustbot