Fix control flow check for breaking with diverging values #77317
Conversation
|
r? @lcnr (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jyn514
added
A-control-flow
varkor
force-pushed
the
break-diverging-value
branch
from
974a61c to
6200e69
Compare
|
This is now ready to review. |
|
LGTM don't have much experience with this part of the code though, so r? @eddyb for a final review/approval |
LeSeulArtichaut
added
S-waiting-on-review
varkor
force-pushed
the
break-diverging-value
branch
from
6200e69 to
d415fae
Compare
src/test/ui/break-diverging-value.rs
Outdated
| } | ||
|
|
||
| fn loop_break_return_2() -> i32 { //~ ERROR mismatched types | ||
| let loop_value = loop { break { return; () } }; |
There was a problem hiding this comment.
Can you change this to break { return 0; () }?
I think in this case I expect // ok, same as break return 0, do you agree?
There was a problem hiding this comment.
I agree. However, apparently break { return 0 } (and your example) behave differently than break return 0, so I shall have to investigate.
There was a problem hiding this comment.
I believe this is because of the point that @eddyb raised earlier.
There was a problem hiding this comment.
That did fix it, thanks both. I added the test and it's working as expected now.
|
@bors r+ |
|
📌 Commit d1c2815 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Fixes #77156.