Improve wording for external crate resolution error #77379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it reads better this way.
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
added
A-diagnostics
camelid
commented
Sep 30, 2020
| @@ -1157,7 +1157,7 @@ impl<'a, 'b> ImportResolver<'a, 'b> { | |||
| } | |||
| _ => { | |||
| if !ident.is_path_segment_keyword() { | |||
| format!("no `{}` external crate", ident) | |||
| format!("no external crate `{}`", ident) | |||
There was a problem hiding this comment.
I considered changing it to "no external crate named", but I didn't want to be wordy. What do you think?
Suggested change
| format!("no external crate `{}`", ident) | |
| format!("no external crate named `{}`", ident) |
There was a problem hiding this comment.
I think that the PR's current wording is fine, but I don't feel strongly - either is an improvement.
|
@bors r=davidtwco |
|
@camelid: 🔑 Insufficient privileges: Not in reviewers |
|
Oh well, worth a try :) |
|
@bors r=davidtwco rollup |
|
📌 Commit 2c5e2a6 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it reads better this way.