Skip to content

Fix tooltip text display #77644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

GuillaumeGomez
Copy link
Member

Currently, when we hover the icon, the text doesn't show up:

Screenshot from 2020-10-07 11-30-44

The bug was spotted by @Nemo157

r? @jyn514

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2020
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2020
@Nemo157
Copy link
Member

Nemo157 commented Oct 7, 2020

Quickly checking stable and beta it looks like it regressed in 1.47, but probably too late to backport?

@jyn514
Copy link
Member

jyn514 commented Oct 7, 2020

The 1.47 release is tomorrow morning, so yeah I don't think it makes sense to backport. Maybe from nightly to beta but certainly not to stable.

@jyn514
Copy link
Member

jyn514 commented Oct 7, 2020

@bors r+ rollup

Tested this on https://doc.rust-lang.org/nightly/std/string/struct.String.html with devtools and it seems to work.

@bors
Copy link
Collaborator

bors commented Oct 7, 2020

📌 Commit 0e45ad8 has been approved by jyn514

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 7, 2020
@bors
Copy link
Collaborator

bors commented Oct 8, 2020

⌛ Testing commit 0e45ad8 with merge 1565699...

@bors
Copy link
Collaborator

bors commented Oct 8, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing 1565699 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2020
@bors bors merged commit 1565699 into rust-lang:master Oct 8, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 8, 2020
@GuillaumeGomez GuillaumeGomez deleted the fix-tooltip-text-display branch October 8, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants