Skip to content

<[T]>::reverse: Fix pointer provenance rules #78816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

SkiFire13
Copy link
Contributor

Should fix #78749

@rust-highfive
Copy link
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2020
@RalfJung
Copy link
Member

This looks great, thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2020

📌 Commit 23d8276 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@bors
Copy link
Collaborator

bors commented Nov 22, 2020

⌛ Testing commit 23d8276 with merge 828461b...

@bors
Copy link
Collaborator

bors commented Nov 22, 2020

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 828461b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2020
@bors bors merged commit 828461b into rust-lang:master Nov 22, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 22, 2020
@SkiFire13 SkiFire13 deleted the fix-slice-pointer-provenance branch November 22, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vec::sort violates pointer provenance rules according to Miri
6 participants