Make rust-mode derive from prog-mode if available
#7948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I incorporated these changes in #8031, closing this PR. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
Lint for bool to integer casts in `cast_lossless` The lint description says > Checks for casts between *numerical* types that may be replaced by safe conversion functions. Which is strictly speaking being violated here, but it seems within the spirit of the lint. I think it is still a useful lint to have, and having a different lint for just this feels excessive. Thoughts? Fixes rust-lang#7947 changelog: Lint for bool to integer casts in [`cast_lossless`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let rust-mode be classified as a programming mode, which is only relevant to Emacs 24.x. This way, for one thing,
prog-mode-hooks will be run when enteringrust-mode.