Skip to content

Bump dependencies invalidly assuming memory layout of SocketAddr #79482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

faern
Copy link
Contributor

@faern faern commented Nov 28, 2020

Bumps net2, socket2 and miow.
Helps unblock #78802

Done as separate PR since frequent lockfile collisions is a thing... And since the main PR can't be merged until large parts of the ecosystem uses the newer crates only, so we have to start somewhere.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Nov 28, 2020

📌 Commit fccdef8762ad692b29b6f632049fbdffdce3d0e0 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2020
@bors
Copy link
Collaborator

bors commented Nov 28, 2020

⌛ Testing commit fccdef8762ad692b29b6f632049fbdffdce3d0e0 with merge 0d27e4d1ab28f7c507fd380b31823939aa703fe9...

@bors
Copy link
Collaborator

bors commented Nov 28, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2020
@faern
Copy link
Contributor Author

faern commented Nov 28, 2020

I'm not sure I understand the CI failure. It fails at the "Mark the job as a failure" task. Not sure what went wrong or if this PR caused it or if it's just sporadic.

@Mark-Simulacrum
Copy link
Member

Illumos builder failed; https://github.com/rust-lang-ci/rust/runs/1467496350#step:24:11749 -- bors doesn't link to the real cause, you have to scroll to find a red checkmark.

@faern
Copy link
Contributor Author

faern commented Nov 28, 2020

Ah. Yeah ok. Looks like socket2 0.3.17 added a bunch of code relying on TCP_MAXSEG. This does not exist in libc for illumos yet. Or it was just merged, but not published: rust-lang/libc#1984

So I resorted to downgrading to socket2 0.3.16 for now. It's still strictly an upgrade in this PR, but just not to the very latest version.

@Mark-Simulacrum
Copy link
Member

Please squash commits. If you'd like to note the problem with 0.3.17 in the commit message that would be fine, but I don't think we need a separate commit.

@faern faern force-pushed the bump-dependencies-invalidly-assuming-mem-layout branch from baa2ea0 to f9220c3 Compare November 29, 2020 09:51
@faern
Copy link
Contributor Author

faern commented Nov 29, 2020

@Mark-Simulacrum Done

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2020

📌 Commit f9220c3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2020
@bors
Copy link
Collaborator

bors commented Nov 29, 2020

⌛ Testing commit f9220c3 with merge 88b8197...

@bors
Copy link
Collaborator

bors commented Nov 29, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 88b8197 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 29, 2020
@bors bors merged commit 88b8197 into rust-lang:master Nov 29, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 29, 2020
@faern faern deleted the bump-dependencies-invalidly-assuming-mem-layout branch November 29, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants