Allow uint discriminants. Fixes #7994. #8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, does this disallow literals like -1 for discriminants? |
|
It shouldn't.... I should probably have tested that actually. It shouldn't disallow anything that was allowed before; I just changed mk_int() to mk_int_var(...) where it decided to care about the type, so as long as the discriminant parses into something that looks like a signed or unsigned integer, it should be fine. |
|
Could you add a test (even to the same test file) exercising this functionality? |
Infers type of constants used as discriminants and ensures they are integral, instead of forcing them to be a signed integer. Also, stores discriminant values as uint instead of int interally and deals with related fallout. Fixes issue rust-lang#7994
bors
added a commit
that referenced
this pull request
Jul 25, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
Don't check for a nightly toolchain in fmt test changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.