Simplify up_to_date to call metadata once.
#80757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also eliminates a use of a `Path` convenience function, in support of rust-lang#80741, refactoring `std::path` to focus on pure data structures and algorithms.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I am not sure I would call this a simplification - it seems harder to understand to me - and this code isn't really worried about TOCTOU or similar problems I think? I'm personally not sure we should deprecate these methods anyway... |
|
Yes, the feedback from #80741 and elsewhere is to not deprecate these methods. With that, this PR is just a minor optimization, making |
|
Yes, I think readability here is more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also eliminates a use of a
Pathconvenience function, in supportof #80741, refactoring
std::pathto focus on pure data structures andalgorithms.