-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Reduce log level used by tracing instrumentation from info to debug #81350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b291bf
to
59457ab
Compare
Could the description and/or the commit message be adjusted to include a few sentences outlining the rationale? |
is there a way to set the default |
I think it is impossible to change the default currently. |
Ok, then let's do this. One rationale could be to not have these spans in the regular rustc, but only in the debug-assertions version |
@bors r+ rollup
I don't know much about |
📌 Commit 59457ab has been approved by |
Tracing |
@bors rollup=never - I'm worried this could have perf implications |
☀️ Test successful - checks-actions |
Restore log level to debug to avoid make info log level overly verbose (the uses of instrument attribute modified there, were for the most part a replacement for
debug!
; one use was novel).