Skip to content

Find codegen backends in more locations #81641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

Find codegen backends in more locations #81641

merged 1 commit into from
Apr 6, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 1, 2021

  • Search in the sysroot passed using --sysroot in addition to the default sysroot.
  • Search for librustc_codegen_$name.so in addition to librustc_codegen_$name-$release.so.

This combined would allow putting librustc_codegen_cranelift.so in the right location of a sysroot passed using --sysroot.

@bjorn3
Find codegen backends in more locations
7f19a2d 
* Search in the sysroot passed using `--sysroot` in addition to the
  default sysroot.
* Search for `librustc_codegen_$name.so` in addition to
  `librustc_codegen_$name-$release.so`.
@bjorn3 bjorn3 added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2021
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2021
@Dylan-DPC-zz
Copy link

r? @davidtwco

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 5, 2021

📌 Commit 7f19a2d has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2021
@bors
Copy link
Collaborator

bors commented Apr 6, 2021

⌛ Testing commit 7f19a2d with merge 354cc75...

@bors
Copy link
Collaborator

bors commented Apr 6, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 354cc75 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 6, 2021
@bors bors merged commit 354cc75 into rust-lang:master Apr 6, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 6, 2021
@bjorn3 bjorn3 deleted the find_codegen_backend branch April 6, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
10 participants
@bjorn3 @rust-highfive @Dylan-DPC-zz @davidtwco @bors @crlf0710 @bstrie @JohnCSimon @matthewjasper @rustbot