Clean tests.mk #8166
Closed
Clean tests.mk #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Aug 1, 2013
Hello, While looking at `tests.mk` I noticed two errors: - there's a `srcrustllvm` instead of `src/rustllvm` - some filtered out files don't exist anymore These two commits fix these issues. Thanks!
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 30, 2021
fix an ICE on unwrapping a None This very likely fixes rust-lang#8166 though I wasn't able to meaningfully reduce a test case. This line is the only call to `unwrap` within that function, which was the one in the stack trace that triggered the ICE, so I think we'll be OK. `@hackmad` can you pull and build this branch and check if it indeed fixes your problem? --- changelog: Fixed ICE in [`unnecessary_cast`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While looking at
tests.mkI noticed two errors:srcrustllvminstead ofsrc/rustllvmThese two commits fix these issues. Thanks!