Improve long explanation for E0546 #81835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@GuillaumeGomez I didn't add the reference to #61137 when I pushed, so I don't know if you're going to receive a notification. |
|
|
||
| ``` | ||
| #![feature(staged_api)] | ||
| #![stable(since = "1.0.0", feature = "test")] | ||
|
|
||
| #[unstable(feature = "unstable_fn", issue = "none")] // ok! | ||
| #[unstable(feature = "unstable_fn", issue = "none")] |
There was a problem hiding this comment.
Ok, I'm going to add it also here then. Isn't it? :)
There was a problem hiding this comment.
Arf indeed! Sorry, didn't pay enough attention...
There was a problem hiding this comment.
Don't worry, I think now I have everything to do it properly in the net PRs. Thanks!
GuillaumeGomez
approved these changes
Feb 7, 2021
|
Thanks! @bors: r+ rollup squash |
|
📌 Commit ac6c09a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#81526 (btree: use Option's unwrap_unchecked()) - rust-lang#81742 (Add a note about the correctness and the effect on unsafe code to the `ExactSizeIterator` docs) - rust-lang#81830 (Add long error explanation for E0542) - rust-lang#81835 (Improve long explanation for E0546) - rust-lang#81843 (Add regression test for rust-lang#29821) Failed merges: - rust-lang#81836 (Add long explanation for E0547) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #61137