Skip to content

Rename IpAddr -> SocketAddr, extract IpAddr from SocketAddr #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

multicast functions now take IpAddr (without port), because they dont't
need port.

Uv* types renamed:

  • UvIpAddr -> UvSocketAddr
  • UvIpv4 -> UvIpv4SocketAddr
  • UvIpv6 -> UvIpv6SocketAddr

"Socket address" is a common name for (ip-address, port) pair (e.g. in
sockaddr_in struct).

P. S. Are there any backward compatibility concerns? What is std::rt module, is it a part of public API?

multicast functions now take IpAddr (without port), because they dont't
need port.

Uv* types renamed:
* UvIpAddr -> UvSocketAddr
* UvIpv4 -> UvIpv4SocketAddr
* UvIpv6 -> UvIpv6SocketAddr

"Socket address" is a common name for (ip-address, port) pair (e.g. in
sockaddr_in struct).
@pcwalton
Copy link
Contributor

pcwalton commented Aug 3, 2013

r? @brson

@brson
Copy link
Contributor

brson commented Aug 4, 2013

This looks right to me. Thanks!

Most of rt is not public API, but rt::io will be moved to std::io, so is all public API. There are no backwards compatibility concerns here though since we're still designing it, and this is an improvement.

bors added a commit that referenced this pull request Aug 4, 2013
multicast functions now take IpAddr (without port), because they dont't
need port.

Uv* types renamed:
* UvIpAddr -> UvSocketAddr
* UvIpv4 -> UvIpv4SocketAddr
* UvIpv6 -> UvIpv6SocketAddr

"Socket address" is a common name for (ip-address, port) pair (e.g. in
sockaddr_in struct).

P. S. Are there any backward compatibility concerns? What is std::rt module, is it a part of public API?
@bors bors closed this Aug 4, 2013
@stepancheg stepancheg deleted the ipv branch December 6, 2013 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants