Highlight sigils and operators in Vim. #8251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigil highlighting isn't perfect (especially how it handles ``&``) but after having used it for a week I feel it to be considerably nicer than nothing. As usual, if you don't like it, you can turn it off easily by overriding the default highlighting. Generics are not handled specially; this means that for something like ``S<T>``, the ``<`` and ``>`` are highlighted as operators. For myself, I like this, and there is no way to make it properly context aware without expanding the syntax matching enormously. Also, special characters are highlighted properly in strings/chars, e.g. ``"\x00"`` or ``'\Ufedcba98'`` appropriately.
| @@ -17,7 +17,7 @@ syn keyword rustOperator as | |||
| syn match rustAssert "\<assert\(\w\)*!" contained | |||
| syn match rustFail "\<fail\(\w\)*!" contained | |||
| syn keyword rustKeyword break copy do extern | |||
| syn keyword rustKeyword for if impl let log | |||
| syn keyword rustKeyword foreach in if impl let log | |||
thestinger
added a commit
that referenced
this pull request
Aug 4, 2013
Highlight sigils and operators in Vim. r=huonw, known spurious failure on one bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigil highlighting isn't perfect (especially how it handles
&) butafter having used it for a week I feel it to be considerably nicer than
nothing. As usual, if you don't like it, you can turn it off easily by
overriding the default highlighting.
Generics are not handled specially; this means that for something like
S<T>, the<and>are highlighted as operators. For myself,I like this, and there is no way to make it properly context aware
without expanding the syntax matching enormously.
Also, special characters are highlighted properly in strings/chars, e.g.
"\x00"or'\Ufedcba98'appropriately.