Skip to content

Update to rustc-rayon 0.3.1 #82999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Update to rustc-rayon 0.3.1 #82999

merged 1 commit into from
Mar 15, 2021

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 11, 2021

This pulls in rust-lang/rustc-rayon#8 to fix #81425. (h/t @ammaraskar)

That revealed weak constraints on rustc_arena::DropArena, because its
DropType was holding type-erased raw pointers to generic T. We can
implement Send for DropType (under cfg(parallel_compiler)) by
requiring all T: Send before they're type-erased.

@cuviper
Update to rustc-rayon 0.3.1
f7e75a2 
This pulls in rust-lang/rustc-rayon#8 to fix rust-lang#81425. (h/t @ammaraskar)

That revealed weak constraints on `rustc_arena::DropArena`, because its
`DropType` was holding type-erased raw pointers to generic `T`. We can
implement `Send` for `DropType` (under `cfg(parallel_compiler)`) by
requiring all `T: Send` before they're type-erased.
@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2021
@varkor
Copy link
Member

varkor commented Mar 13, 2021

Looks fine to me, but I'm not confident I wouldn't overlook some subtlety here, so I'd rather reassign (based on blame).

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

📌 Commit f7e75a2 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Testing commit f7e75a2 with merge 6d531114c5607bdb63c459e08ac5d9168350d8e2...

@bors
Copy link
Collaborator

bors commented Mar 14, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2021
@JohnTitor
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2021
@bors
Copy link
Collaborator

bors commented Mar 15, 2021

⌛ Testing commit f7e75a2 with merge 841f24fedd4117c725ea60e802bf129a5119f6be...

@bors
Copy link
Collaborator

bors commented Mar 15, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2021
@JohnTitor
Copy link
Member 

2021-03-15T01:15:23.9706401Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest'
2021-03-15T01:15:24.3087170Z Can't find any online and idle self-hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest'
2021-03-15T01:15:24.8420600Z Found online and idle hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest'
2021-03-15T01:15:25.0844018Z ##[section]Finishing: Request a runner to run this job

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2021
@bors
Copy link
Collaborator

bors commented Mar 15, 2021

⌛ Testing commit f7e75a2 with merge a69bfdd9f201d1f1c424060adac9047a8ed71d16...

@bors
Copy link
Collaborator

bors commented Mar 15, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@JohnTitor
Copy link
Member

Same failure, @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2021
@bors
Copy link
Collaborator

bors commented Mar 15, 2021

⌛ Testing commit f7e75a2 with merge 2a55274...

@bors
Copy link
Collaborator

bors commented Mar 15, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2a55274 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2021
@bors bors merged commit 2a55274 into rust-lang:master Mar 15, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 15, 2021
@cuviper cuviper deleted the rustc-rayon-0.3.1 branch September 21, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Loose Send/Sync bounds for WorkerLocal used in rayon fork for parallel-compiler
8 participants
@cuviper @rust-highfive @varkor @Mark-Simulacrum @bors @JohnTitor @rust-log-analyzer @rustbot