Add simd_neg platform intrinsic #83271
Conversation
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| @@ -1628,7 +1628,7 @@ unsupported {} from `{}` with element `{}` of size `{}` to `{}`"#, | |||
| out_elem | |||
| ); | |||
| } | |||
| macro_rules! arith { | |||
| macro_rules! arith_bin { | |||
There was a problem hiding this comment.
These just get defined once and invoked once, so they don't need to be abbreviated. How about arith_binary and arith_unary?
There was a problem hiding this comment.
Thanks for pointing. It has been corrected.
|
Naming nit aside, LGTM. |
|
@bors r+ |
|
📌 Commit b93590e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Stdarch needs to add simd_neg to support the implementation of vneg neon instructions. Look here