Skip to content

ffi::c_str removed bound checks on as_bytes, to_bytes #83609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2021
Merged

ffi::c_str removed bound checks on as_bytes, to_bytes #83609

merged 2 commits into from
Mar 29, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Mar 28, 2021

This removes bound checks on CString::as_bytes() and CStr::to_bytes() and adds test.

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2021
m-ou-se
m-ou-se reviewed Mar 28, 2021
View reviewed changes
@m-ou-se
Copy link
Member

m-ou-se commented Mar 29, 2021

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 29, 2021

📌 Commit a0ff461 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2021
@bors
Copy link
Collaborator

bors commented Mar 29, 2021

⌛ Testing commit a0ff461 with merge 7750402...

@bors
Copy link
Collaborator

bors commented Mar 29, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 7750402 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 29, 2021
@bors bors merged commit 7750402 into rust-lang:master Mar 29, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
5 participants
@klensy @rust-highfive @m-ou-se @bors @rustbot