-
Notifications
You must be signed in to change notification settings - Fork 13.3k
doc asm feature - Added new 'Label' section with example and explanations #84015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
https://github.com/rust-lang/rust/pull/84015/checks?check_run_id=2305123299 It seems to me that the |
Ouch, I thought that bug was fixed in LLVM 10. It seems that it is only fixed in 10.0.1, which our CI doesn't have. So we may have to add |
Can you run the examples manually on the playground to ensure they work with the nightly compiler? |
This comment has been minimized.
This comment has been minimized.
Note that the issue here is that LLVM is incorrectly adding |
So, I built the doc locally, opened it in my browser and ran each example by clicking on the play arrow. They all worked fine. I have added the |
@bors r+ rollup |
📌 Commit 1f7de3f has been approved by |
This is my first PR to the rust repo so I'm unsure: is there something I'm expected to do before we merge this PR ? |
☀️ Test successful - checks-actions |
Nope! Once the pull request is approved with r+, bors will automatically merge it after running tests. |
Nice ! Thanks for you help and review ! |
Fixes #76704