Skip to content

doc asm feature - Added new 'Label' section with example and explanations #84015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2021
Merged

doc asm feature - Added new 'Label' section with example and explanations #84015

merged 8 commits into from
Apr 10, 2021

Conversation

tdelabro
Copy link
Contributor

@tdelabro tdelabro commented Apr 8, 2021

Fixes #76704

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@tdelabro
Copy link
Contributor Author

tdelabro commented Apr 9, 2021

@Amanieu

https://github.com/rust-lang/rust/pull/84015/checks?check_run_id=2305123299

It seems to me that the asm! block are converted to the AT&T asm syntax, while we are using the intel one all along the documentation, making it unable to recognise the used symbols.

@Amanieu
Copy link
Member

Amanieu commented Apr 9, 2021

Ouch, I thought that bug was fixed in LLVM 10. It seems that it is only fixed in 10.0.1, which our CI doesn't have. So we may have to add allow_fail back to make CI pass.

@Amanieu
Copy link
Member

Amanieu commented Apr 9, 2021

Can you run the examples manually on the playground to ensure they work with the nightly compiler?

@rust-log-analyzer

This comment has been minimized.

@Amanieu
Copy link
Member

Amanieu commented Apr 9, 2021

Note that the issue here is that LLVM is incorrectly adding % to register names even though we have told it to use Intel syntax. This is fixed in LLVM 10.0.1.

@tdelabro
Copy link
Contributor Author

tdelabro commented Apr 9, 2021

So, I built the doc locally, opened it in my browser and ran each example by clicking on the play arrow. They all worked fine.

I have added the allow_fail flags back. It should pass the CI now.

@Amanieu
Copy link
Member

Amanieu commented Apr 9, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 9, 2021

📌 Commit 1f7de3f has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2021
@tdelabro
Copy link
Contributor Author

tdelabro commented Apr 9, 2021

This is my first PR to the rust repo so I'm unsure: is there something I'm expected to do before we merge this PR ?

@bors
Copy link
Collaborator

bors commented Apr 10, 2021

⌛ Testing commit 1f7de3f with merge dbcf345...

@bors
Copy link
Collaborator

bors commented Apr 10, 2021

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing dbcf345 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2021
@bors bors merged commit dbcf345 into rust-lang:master Apr 10, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 10, 2021
@Amanieu
Copy link
Member

Amanieu commented Apr 10, 2021

This is my first PR to the rust repo so I'm unsure: is there something I'm expected to do before we merge this PR ?

Nope! Once the pull request is approved with r+, bors will automatically merge it after running tests.

@tdelabro
Copy link
Contributor Author

Nice ! Thanks for you help and review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable book: explaining how to properly use labels in inline asm
7 participants