Skip to content

Move some tests to more reasonable directories - 6 #84065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

c410-f3r
Copy link
Contributor

cc #73494
r? @petrochenkov

git mv bad/bad-const-type.* static/
git mv bad/bad-crate-name.* extern
git mv bad/bad-env-capture* fn/
git mv bad/bad-expr-lhs.* expr/
git mv bad/bad-expr-path* expr/
git mv bad/bad-extern-link-attrs.* extern/
git mv bad/bad-intrinsic-monomorphization.* intrinsics/
git mv bad/bad-lint-cap* lint/
git mv bad/bad-main.* fn
git mv bad/bad-method-typaram-kind.* type/
git mv bad/bad-mid-path-type-params.* fn
git mv bad/bad-module.* modules/
git mv bad/bad-sized.* type/
git mv bad/bad-type-env-capture.* fn

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2021
@petrochenkov
Copy link
Contributor

bad-expr-lhs.rs -> destructuring-assignment
bad-expr-path.rs -> resolve
bad-expr-path2.rs -> resolve
bad-crate-name.rs -> parser
bad-extern-link-attrs.rs -> linkage-attr
bad-mid-path-type-params.rs -> generics, probably
bad-env-capture(1,2,3).rs -> resolve
bad-type-env-capture.rs -> resolve
bad-module.rs -> resolve
bad-method-typaram-kind.rs -> traits
bad-sized.rs -> traits

(The list largely matches suggestions from classifui.)
Tidy also needs to be updated.

Subdirectories like expr or fn are almost as meaningless as bad, TBH.
I'm trying to classify tests by compiler areas, because compiler areas in their turn map on people who will maintain tests in a given subdirectory.
Let's say, I'm maintaining name resolution and want to bring some order to name resolution tests, remove garbage and duplicates, etc. (Const eval working group may want to do the same things with constant evaluation, etc.). Then we'll know where to find relevant tests.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2021
@c410-f3r c410-f3r force-pushed the tests-tests-tests branch from ff01ba8 to 46811d7 Compare April 17, 2021 21:39
@c410-f3r c410-f3r force-pushed the tests-tests-tests branch from 46811d7 to 4e6d6ab Compare April 17, 2021 21:54
@c410-f3r
Copy link
Contributor Author

Thanks for the review @petrochenkov. All provided information will surely help in the next PR.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 17, 2021

📌 Commit 4e6d6ab has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2021
@bors
Copy link
Collaborator

bors commented Apr 18, 2021

⌛ Testing commit 4e6d6ab with merge 6765010...

@bors
Copy link
Collaborator

bors commented Apr 18, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6765010 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2021
@bors bors merged commit 6765010 into rust-lang:master Apr 18, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants