Mark has_global_allocator query as eval_always

[Aaron1011]

Fixes #84252

This query reads from untracked global state in CStore.

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[Spaceface16518]

@Aaron1011 that was fast 😮

[Aaron1011]

@Spaceface16518: This issue is very similar to other ones which have been exposed recently - the fix tends to be the same 😄

[Spaceface16518]

So is my code now valid or a compiler error?

[Aaron1011]

@Spaceface16518: Your code was perfectly fine - the ICE was due to a compiler bug related to incremental compilation. Applying a #[cfg] to a #[global_allocator] item is perfectly correct.

For now, you can work around this bug by running cargo clean. You'll also need to clear out the Github Actions cache, as it's the cached build directory that's responsible for the crash.

[Spaceface16518]

Oh I see, that makes sense. Thank you, I'll do that.

[cjgillot]

@bors r+

[bors]

📌 Commit 169a221 has been approved by cjgillot

[bors]

⌛ Testing commit 169a221 with merge cd9b305...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing cd9b305 to master...