Skip to content

Make rustc_dirty/clean annotations exhaustive by default #85331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2021
Merged

Make rustc_dirty/clean annotations exhaustive by default #85331

merged 3 commits into from
Jun 2, 2021

Conversation

cjgillot
Copy link
Contributor

Fixes #45009

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2021
@jackh726
Copy link
Member

I feel bad for doing r? @Aaron1011 but I'm not sure who's better at the moment

@rust-highfive rust-highfive assigned Aaron1011 and unassigned jackh726 May 15, 2021
@Aaron1011
Copy link
Member

@cjgillot: Are there any remaining uses of #[rustc_dirty]? If not, could you remove the attribute?

@cjgillot cjgillot closed this May 16, 2021
@cjgillot cjgillot reopened this May 16, 2021
@Aaron1011
Copy link
Member

cc @michaelwoerister - does this look good to you?

@bors
Copy link
Collaborator

bors commented Jun 1, 2021

☔ The latest upstream changes (presumably #85153) made this pull request unmergeable. Please resolve the merge conflicts.

@michaelwoerister
Copy link
Member

This looks good to me in general, yes. Thanks for the PR, @cjgillot!

@Aaron1011
Copy link
Member

r=me with the merge conflicts addressed.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 1, 2021

@bors r=Aaron1011

@bors
Copy link
Collaborator

bors commented Jun 1, 2021

📌 Commit fc069d3 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2021
@bors
Copy link
Collaborator

bors commented Jun 1, 2021

⌛ Testing commit fc069d3 with merge 153f22a...

@bors
Copy link
Collaborator

bors commented Jun 2, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 153f22a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2021
@bors bors merged commit 153f22a into rust-lang:master Jun 2, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 2, 2021
This was referenced Jun 2, 2021
Merged
Merged
@cjgillot cjgillot deleted the dirty-dancing branch June 2, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

tracking issue for rustc_dirty/clean enhancements
7 participants
@cjgillot @rust-highfive @jackh726 @Aaron1011 @bors @michaelwoerister @rustbot