Correctly handle remapping from path containing the current directory with trailing paths #85344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
May 16, 2021
bstrie
added
S-waiting-on-review
crlf0710
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
There was a problem hiding this comment.
Thank you for the PR, @cbeuw!
I left some comments below for making the test case more robust. Otherwise this is good to merge.
michaelwoerister
added
S-waiting-on-author
|
@michaelwoerister All addressed. Thanks for reviewing! |
camelid
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 08c55bd has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 08c55bd with merge a6e1d5007597713f57bba6f231b4fce0d9ce39fb... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
inquisitivecrystal
added
the
T-compiler
|
@bors r+ |
|
📌 Commit 7ed9f2e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a
auxiliary/lib.rs, and we generate the metadata with--remap-path-prefix $PWD/auxiliary=xyz, the path to$PWD/auxiliary/lib.rswon't be correctly remapped in the metadata. This is because internally, path to the working directory itself and relative paths to files under the working directory are remapped separately (hence neither are affected since neither has$PWD/auxiliaryas prefix), but the concatenation between the working directory and the relative path is not remapped. This PR fixes that.