Skip to content

Add rustc_mir::interpret::Machine::enforce_abi() #85557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from May 22, 2021
Merged

Add rustc_mir::interpret::Machine::enforce_abi() #85557

merged 2 commits into from May 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2021

To specify whether to skip the ABI check for function calls, so that we could test unwinding out of a extern "C" function call in Miri by disabling the check: rust-lang/miri#1776 (comment)

I have tested that it works in Miri with a -Zmiri-disable-abi-check command line flag.

@rust-highfive
Copy link
Contributor

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2021
@RalfJung
Copy link
Member

r? @RalfJung
This looks great, thanks. :)
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2021

📌 Commit c69fba9 has been approved by RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned lcnr May 22, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2021
@bors
Copy link
Collaborator

bors commented May 22, 2021

⌛ Testing commit c69fba9 with merge 6445ac8c16b5759ec367d7f4f58791e36b29a55b...

@RalfJung
Copy link
Member

@bors retry r-
oops I misread...
could you please add a default implementation for this method?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2021
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member

Thanks :)
@bors r+

@bors
Copy link
Collaborator

bors commented May 22, 2021

📌 Commit 7e42c97 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 22, 2021
@bors
Copy link
Collaborator

bors commented May 22, 2021

⌛ Testing commit 7e42c97 with merge d53219b491e71c6b7f4d09069dd1904cae55533a...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung
Copy link
Member

No job actually failed though...? Very strange.
@bors retry

@bors
Copy link
Collaborator

bors commented May 22, 2021

⌛ Testing commit 7e42c97 with merge 104a3c3...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung
Copy link
Member

I think bors is just broken...

@bors
Copy link
Collaborator

bors commented May 22, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 104a3c3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2021
@bors bors merged commit 104a3c3 into rust-lang:master May 22, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 22, 2021
@ghost ghost deleted the abi branch May 22, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants