Skip to content

Check whether the closure's owner is an ADT in thir-unsafeck #86138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions compiler/rustc_mir_build/src/check_unsafety.rs
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,15 @@ pub fn check_unsafety<'tcx>(tcx: TyCtxt<'tcx>, def: ty::WithOptConstParam<LocalD
return;
}

// Closures are handled by their parent function
// Closures are handled by their owner, if it has a body
if tcx.is_closure(def.did.to_def_id()) {
tcx.ensure().thir_check_unsafety(tcx.hir().local_def_id_to_hir_id(def.did).owner);
return;
let owner = tcx.hir().local_def_id_to_hir_id(def.did).owner;
let owner_hir_id = tcx.hir().local_def_id_to_hir_id(owner);

if tcx.hir().maybe_body_owned_by(owner_hir_id).is_some() {
tcx.ensure().thir_check_unsafety(owner);
return;
}
}

let (thir, expr) = tcx.thir_body(def);
Expand Down
20 changes: 20 additions & 0 deletions src/test/ui/thir-unsafeck-issue-85871.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Tests that no ICE occurs when a closure appears inside a node
// that does not have a body when compiling with
// compile-flags: -Zthir-unsafeck=yes
// check-pass

#![allow(dead_code)]

struct Bug {
inner: [(); match || 1 {
_n => 42, // we may not call the closure here (E0015)
}],
}

enum E {
V([(); { let _ = || 1; 42 }]),
}

type Ty = [(); { let _ = || 1; 42 }];

fn main() {}