Skip to content

Move some UI tests to more suitable subdirs #86522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jun 21, 2021

cc #73494
The classified result is here: https://gist.github.com/JohnTitor/c9e00840990b5e4a8fc562ec3571e427

  • issues/issue-27060.rs: misclassified, should be packed.
  • issues/issue-45157.rs: moved to nll.
  • issues/issue-69532.rs: couldn't figured out the best place, placed a new llvm dir moved to consts.
  • fsu-moves-and-copies.rs: moved to borrowck.
  • issues/issue-36638.rs: misclassified, moved to keyword.
  • issues/issue-48636.rs: moved to parser.
  • issues/issue-37655.rs: I'm not sure but associated-types shouldn't the best, moved to coercion but region may be better.
  • issues/issue-20005.rs: moved to associated-types.
  • issues/issue-82869.rs: moved to asm.
  • issues/issue-24535-allow-mutable-borrow-in-match-guard.rs: moved to nll.
  • issues/issue-52169.rs: moved to macros.
  • test-passed.rs: moved to test-attrs along with test- prefixed tests.
    • test-cfg.rs: moved to conditional-compilation.
  • non-integer-atomic.rs: moved to intrinsics.
  • issues/issue-54521-2.rs: moved to parser.
  • issues/issue-17756.rs: moved to consts.
  • conversion-methods.rs: moved to suggestions moved to typeck.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2021
@petrochenkov
Copy link
Contributor

issue-69532.rs -> consts (apfloat is our own const eval, not llvm, even if it's cloned from llvm)
conversion-methods.rs -> typeck (the suggestions subdirectory is meaningless)
test-cfg.rs -> conditional-compilation (no #[test] in sight)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2021
@JohnTitor
Copy link
Member Author

Thanks, updated.

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 29, 2021

📌 Commit 2c62686 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2021
@bors
Copy link
Collaborator

bors commented Jun 29, 2021

⌛ Testing commit 2c62686 with merge 0ce2112...

@bors
Copy link
Collaborator

bors commented Jun 30, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 0ce2112 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 30, 2021
@bors bors merged commit 0ce2112 into rust-lang:master Jun 30, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 30, 2021
@JohnTitor JohnTitor deleted the move-ui-tests branch June 30, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants