Skip to content

Fix typo in libs tracking issue template #86684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

inquisitivecrystal
Copy link
Contributor

@inquisitivecrystal inquisitivecrystal commented Jun 28, 2021

Currently, the libs tracking issue template expands FCP as "final commenting period". Everywhere else, including in the official explanation, it's expanded as "final comment period". That version also sounds a bit better. Accordingly, this PR changes the tracking issue template to use that version.

@rustbot label A-meta T-libs-api
r? @m-ou-se

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 28, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
@inquisitivecrystal
Copy link
Contributor Author

r? @m-ou-se

Someone from libs-api should look at this. I tried to do it in my original comment, but I messed up the syntax.

@m-ou-se
Copy link
Member

m-ou-se commented Jun 28, 2021

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2021

📌 Commit fe54486 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@bors
Copy link
Collaborator

bors commented Jun 28, 2021

⌛ Testing commit fe54486 with merge 451e98e...

@bors
Copy link
Collaborator

bors commented Jun 28, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 451e98e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 28, 2021
@bors bors merged commit 451e98e into rust-lang:master Jun 28, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants