Skip to content

Various diagnostics clean ups/tweaks #87225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Various diagnostics clean ups/tweaks #87225

merged 1 commit into from
Jul 19, 2021

Conversation

estebank
Copy link
Contributor

  • Always point at macros, including derive macros
  • Point at non-local items that introduce a trait requirement
  • On private associated item, point at definition

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@michaelwoerister
Copy link
Member

The changes look reasonable to me but I'd prefer if someone from @rust-lang/wg-diagnostics reviewed this.

r? @rust-lang/wg-diagnostics

@michaelwoerister
Copy link
Member

(@LeSeulArtichaut & @Mark-Simulacrum, it looks like above r? <team> didn't work. Does the team need to be added explicitly to highfive, maybe?)

@LeSeulArtichaut
Copy link
Contributor

Currently highfive only knows what's declared in there: https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json

If we want to support r? on any team we could add them all in the highfive configs, or fall back to the GitHub team members. The former is more churn, but allows people that e.g. don't have time or are on vacation to opt out.

@estebank
Copy link
Contributor Author

r? @oli-obk :)

@estebank estebank force-pushed the cleanup branch 3 times, most recently from 2f5c832 to 9ce65ac Compare July 19, 2021 15:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Various diagnostics clean ups/tweaks
ba052bd 
* Always point at macros, including derive macros
* Point at non-local items that introduce a trait requirement
* On private associated item, point at definition
oli-obk
oli-obk reviewed Jul 19, 2021
View reviewed changes
compiler/rustc_typeck/src/check/method/suggest.rs
Comment on lines +936 to +940
let sp = self
.tcx
.hir()
.span_if_local(def_id)
.unwrap_or_else(|| self.tcx.def_span(def_id));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pattern could warrant its own helper function

@oli-obk
Copy link
Contributor

oli-obk commented Jul 19, 2021

@bors r+ p=1 bitrotty

@bors
Copy link
Collaborator

bors commented Jul 19, 2021

📌 Commit ba052bd has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2021
@bors
Copy link
Collaborator

bors commented Jul 19, 2021

⌛ Testing commit ba052bd with merge d5af634...

@bors
Copy link
Collaborator

bors commented Jul 19, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d5af634 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 19, 2021
@bors bors merged commit d5af634 into rust-lang:master Jul 19, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 19, 2021
This was referenced Jul 19, 2021
Merged
Closed
Merged
Merged
Merged
@estebank estebank mentioned this pull request Jul 20, 2021
Closed
@estebank estebank deleted the cleanup branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@wooster0 wooster0 wooster0 left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
9 participants
@estebank @rust-highfive @rust-log-analyzer @michaelwoerister @LeSeulArtichaut @oli-obk @bors @wooster0 @rustbot