2229: Don't capture preicese paths on top of a union #87469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Accessing fields of a union require unsafe block - As part of 2229 we don't allow precision where we need an unsafe block to capture. Fixes: rust-lang#87378 r? @nikomatsakis
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Jul 26, 2021
|
@bors r+ |
|
📌 Commit 75edcd9 has been approved by |
bors
added
S-waiting-on-bors
lqd
reviewed
Jul 26, 2021
| @@ -1760,12 +1760,11 @@ impl<'a, 'tcx> euv::Delegate<'tcx> for InferBorrowKind<'a, 'tcx> { | |||
| self.borrow(assignee_place, diag_expr_id, ty::BorrowKind::MutBorrow); | |||
| } | |||
| } | |||
|
|
|||
| /// Truncate projections so that following rules are obeyed by the captured `place`: | |||
| /// Truncate `place` so that an `unsafe` block isn't required to capture it. | |||
There was a problem hiding this comment.
Note the removed newline above this doc comment. (Don't worry about it, no need to block this one from landing. A drive-by fix in one of your next PRs is fine).
lqd
reviewed
Jul 26, 2021
| /// Truncate projections so that following rules are obeyed by the captured `place`: | ||
| /// - No Index projections are captured, since arrays are captured completely. | ||
| /// - No unsafe block is required to capture `place` | ||
| /// Truncate projections so that following rules are obeyed by the captured `place`: |
There was a problem hiding this comment.
And here the first line of the doc comment is duplicated as the last line.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to capture.
Fixes: #87378
r? @nikomatsakis