Skip to content

Add doctests for HashMap's into_values and into_keys methods #87598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add doctests for HashMap's into_values and into_keys methods #87598

merged 1 commit into from
Aug 23, 2021

Conversation

ccqpein
Copy link
Contributor

@ccqpein ccqpein commented Jul 29, 2021 •
edited by JohnTitor
Loading

Fixes #87591

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2021
@ccqpein ccqpein changed the title Add doctests for 's into_values and into_keys methods Add doctests for HashMap's into_values and into_keys methods Jul 29, 2021
lukaslueg
lukaslueg reviewed Jul 29, 2021
View reviewed changes
@camelid
Copy link
Member

camelid commented Jul 30, 2021

Should this PR be marked as closing #87591?

@ChaiTRex
Copy link
Contributor

ChaiTRex commented Aug 4, 2021

@ccqpein Can you please merge the pull request in your repository at ccqpein#1? It clarifies that the order of the elements produced by the iterators is arbitrary.

@ccqpein
Copy link
Contributor Author

ccqpein commented Aug 5, 2021

@ChaiTRex Thanks for your PR, have done!

@yaahc
Copy link
Member

yaahc commented Aug 5, 2021

Looks great.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2021

📌 Commit fb62b8f3207c4f3c849c959a352af6b6de73a228 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2021
@JohnTitor
Copy link
Member

We have the "No-Merge Policy" in this repo, I think we should squash commits into one, could you?

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2021
@JohnCSimon
Copy link
Member

Ping from triage:
@ccqpein - can you please squash the commits and set the S-waiting-on-review tag?
Thanks

@ccqpein
Copy link
Contributor Author

ccqpein commented Aug 22, 2021

@JohnCSimon I squash the commits but I am not sure I can add labels to PR.

@camelid
Copy link
Member

camelid commented Aug 22, 2021

You can do it like this: @rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2021
@ccqpein
Copy link
Contributor Author

ccqpein commented Aug 23, 2021

You can do it like this: @rustbot label: -S-waiting-on-author +S-waiting-on-review

Thank you! Good to know, now I know how to this in my next PR to rustlang

@JohnTitor
Copy link
Member

Thanks!
@bors r=yaahc

@bors
Copy link
Collaborator

bors commented Aug 23, 2021

📌 Commit 6eefee1 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2021
@bors
Copy link
Collaborator

bors commented Aug 23, 2021

⌛ Testing commit 6eefee1 with merge 1c04856...

@bors
Copy link
Collaborator

bors commented Aug 23, 2021

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing 1c04856 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2021
@bors bors merged commit 1c04856 into rust-lang:master Aug 23, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaslueg lukaslueg lukaslueg left review comments

Assignees

@yaahc yaahc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

Better doctests for HashMap's into_values and into_keys methods
10 participants
@ccqpein @rust-highfive @camelid @ChaiTRex @yaahc @bors @JohnTitor @JohnCSimon @lukaslueg @rustbot