Add a hint that the expressions produce a value #87607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, well, well: https://www.githubstatus.com/incidents/8qy34dmg4kdm |
JohnTitor
added
the
S-waiting-on-review
estebank
approved these changes
Jul 30, 2021
compiler/rustc_lint/src/unused.rs
Outdated
Comment on lines
165
to
174
| lint.note(&format!("the {} produces a value", must_use_op)); | ||
| if let Ok(snippet) = cx.sess().source_map().span_to_snippet(expr.span) { | ||
| lint.span_suggestion( | ||
| expr.span, | ||
| "use `let _ = ...` to ignore it", | ||
| format!("let _ = {}", snippet), | ||
| Applicability::MachineApplicable, | ||
| ) | ||
| .emit() | ||
| } |
There was a problem hiding this comment.
Suggested change
| lint.note(&format!("the {} produces a value", must_use_op)); | |
| if let Ok(snippet) = cx.sess().source_map().span_to_snippet(expr.span) { | |
| lint.span_suggestion( | |
| expr.span, | |
| "use `let _ = ...` to ignore it", | |
| format!("let _ = {}", snippet), | |
| Applicability::MachineApplicable, | |
| ) | |
| .emit() | |
| } | |
| lint.span_label(expr.span, &format!("the {} produces a value", must_use_op)); | |
| lint.span_suggestion_verbose( | |
| expr.span, | |
| "use `let _ = ...` to ignore the resulting value", | |
| "let _ = ".to_string(), | |
| Applicability::MachineApplicable, | |
| ); |
There was a problem hiding this comment.
Thanks! Applied it with changing expr.span to expr.span.shrink_to_lo() via 924eddf.
JohnTitor
force-pushed
the
help-to-unused-must-use-op
branch
from
17b2e9f to
924eddf
Compare
|
@bors r=estebank |
|
📌 Commit 924eddf has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85913
The second commit is semi-unrelated but it allows us to run the related tests just on
src/test/ui/lint.