Skip to content

clippy::perf fixes #87686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2021
Comment on lines +225 to +226
let mut ids = ids.into_iter().collect::<SmallVec<[usize; 8]>>();
ids.sort_unstable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this (and lower) sort's need to be stable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are sorting primitives (usizes) here, so it does not matter if we have 1, 1, 1 or 1, 1, 1 :)

@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 2, 2021
@bors
Copy link
Collaborator

bors commented Aug 2, 2021

⌛ Trying commit a953574 with merge 9474e103eafbe1d5f98d8298b44dd59afa1f37f9...

@bors
Copy link
Collaborator

bors commented Aug 2, 2021

☀️ Try build successful - checks-actions
Build commit: 9474e103eafbe1d5f98d8298b44dd59afa1f37f9 (9474e103eafbe1d5f98d8298b44dd59afa1f37f9)

@rust-timer
Copy link
Collaborator

Queued 9474e103eafbe1d5f98d8298b44dd59afa1f37f9 with parent d08460e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (9474e103eafbe1d5f98d8298b44dd59afa1f37f9): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 2, 2021
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2021
@jackh726
Copy link
Member

@bors r+

Simple changes. Theoretical perf improvements, even if nothing on benches.

@bors
Copy link
Collaborator

bors commented Aug 20, 2021

📌 Commit a953574 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2021
@bors
Copy link
Collaborator

bors commented Aug 20, 2021

⌛ Testing commit a953574 with merge d77dcbc...

@bors
Copy link
Collaborator

bors commented Aug 20, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing d77dcbc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 20, 2021
@bors bors merged commit d77dcbc into rust-lang:master Aug 20, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 20, 2021
@matthiaskrgr matthiaskrgr deleted the clippy_august_21_perf branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants