-
Notifications
You must be signed in to change notification settings - Fork 13.4k
clippy::perf fixes #87686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy::perf fixes #87686
Conversation
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
let mut ids = ids.into_iter().collect::<SmallVec<[usize; 8]>>(); | ||
ids.sort_unstable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this (and lower) sort
's need to be stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are sorting primitives (usize
s) here, so it does not matter if we have 1, 1, 1
or 1, 1, 1
:)
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a953574 with merge 9474e103eafbe1d5f98d8298b44dd59afa1f37f9... |
☀️ Try build successful - checks-actions |
Queued 9474e103eafbe1d5f98d8298b44dd59afa1f37f9 with parent d08460e, future comparison URL. |
Finished benchmarking try commit (9474e103eafbe1d5f98d8298b44dd59afa1f37f9): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
@bors r+ Simple changes. Theoretical perf improvements, even if nothing on benches. |
📌 Commit a953574 has been approved by |
☀️ Test successful - checks-actions |
No description provided.