-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Proc macro spans: make columns 1 based #87712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
68e55f3
to
a6f989f
Compare
Note that there are still small differences between proc macro span columns and panic location columns: the panic location counts a tab as 4 characters while the proc macro spans count it as 1 character. However, the |
This comment has been minimized.
This comment has been minimized.
a6f989f
to
7d20789
Compare
This looks reasonable and the API is (perpetually?) unstable, so I'm going to just r+ this. |
📌 Commit 7d20789 has been approved by |
☀️ Test successful - checks-actions |
This makes proc macro spans consistent with the
column!()
macro as well asstd::panic::Location
, as both are 1-based.#54725 (comment)