-
Notifications
You must be signed in to change notification settings - Fork 13.3k
#[inline] slice::Iter::advance_by #87736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e44d39a with merge 6043f941ffb62a53c52d08953a2d8b19441696e0... |
☀️ Try build successful - checks-actions |
Queued 6043f941ffb62a53c52d08953a2d8b19441696e0 with parent d5fd37f, future comparison URL. |
Finished benchmarking try commit (6043f941ffb62a53c52d08953a2d8b19441696e0): comparison url. Summary: This change led to significant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
That recovers the regex-opt regression |
@bors r+ |
📌 Commit e44d39a has been approved by |
☀️ Test successful - checks-actions |
#87387 (comment) was marked as a regression. One of the methods in the PR was missing an inline annotation unlike all the other methods on slice iterators.
Let's see if that makes a difference.