-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update the backtrace crate in libstd #88151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
|
It seems that the update makes it impossible to build std with the
I rather liked this because it shaved of a bit of executable size while keeping unwinding on panics. |
Oh that's an unintended consequence of a historical refactoring in the crate, rust-lang/backtrace-rs#433 should restore support. |
This commit updates the backtrace crate in libstd now that dependencies have been updated to use `memchr` from the standard library as well. This is mostly just making sure deps are up-to-date and have all the latest-and-greatest fixes and such. Closes rust-lang/backtrace-rs#432
d80f6b5
to
4a3e736
Compare
Ok, I've updated the submodule here to include that fix. |
@bors r+ rollup=never |
📌 Commit 4a3e736 has been approved by |
☀️ Test successful - checks-actions |
This was a perf regression, on a number of crates, but I believe it to be entirely or largely due to more metadata decoding and related processing of std, which this PR increased the size of. @rustbot label perf-regression perf-regression-triaged |
This commit updates the backtrace crate in libstd now that dependencies
have been updated to use
memchr
from the standard library as well.This is mostly just making sure deps are up-to-date and have all the
latest-and-greatest fixes and such.
Closes rust-lang/backtrace-rs#432