Skip to content

Move add_rlib and add_native_library to cg_ssa #88559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2021
Merged

Move add_rlib and add_native_library to cg_ssa #88559

merged 1 commit into from
Sep 5, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 1, 2021

This deduplicates logic between codegen backends.

cc @antoyo and @khyperia for cg_gcc and rust-gpu.

@bjorn3
Move add_rlib and add_native_library to cg_ssa
977f279 
This deduplicates logic between codegen backends
@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-cranelift Things relevant to the [future] cranelift backend A-gcc Things relevant to the [future] GCC backend labels Sep 1, 2021
@rust-highfive
Copy link
Contributor

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2021
@cjgillot
Copy link
Contributor

cjgillot commented Sep 3, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2021

📌 Commit 977f279 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2021
@bors
Copy link
Collaborator

bors commented Sep 5, 2021

⌛ Testing commit 977f279 with merge d32dc80...

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing d32dc80 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2021
@bors bors merged commit d32dc80 into rust-lang:master Sep 5, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 5, 2021
@bjorn3 bjorn3 deleted the archive_logic_dedup branch September 5, 2021 07:45
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Sep 19, 2021
@bors
Auto merge of rust-lang#88559 - bjorn3:archive_logic_dedup, r=cjgillot
771c2c6 
Move add_rlib and add_native_library to cg_ssa

This deduplicates logic between codegen backends.

cc `@antoyo` and `@khyperia` for cg_gcc and rust-gpu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
A-cranelift Things relevant to the [future] cranelift backend A-gcc Things relevant to the [future] GCC backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rust-highfive @cjgillot @bors @rustbot